Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[review] Logging response MB and KB/s #90

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[review] Logging response MB and KB/s #90

merged 1 commit into from
Jul 20, 2023

Conversation

JunichiIto
Copy link
Contributor

@JunichiIto JunichiIto commented Jul 20, 2023 •
edited
Loading

どれくらいの容量をダウンロードして、どれくらいの速度でダウンロードで来たいのかを知りたいので。

出力例

** [CopyTuner] [P:49011] [T:8440] Start downloading translations
** [CopyTuner] [P:49011] [T:8440] Downloaded translations (179139ms, 9.0MB, 51.5KB/s)

@JunichiIto JunichiIto changed the title Logging response MB and KB/s [review] Logging response MB and KB/s Jul 20, 2023
aki77
aki77 approved these changes Jul 20, 2023
View reviewed changes
Copy link
Contributor

@aki77 aki77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
ちなみに出力例って実際の値ですか？（遅すぎて気になった）

@aki77 aki77 merged commit 33d5a86 into master Jul 20, 2023
@aki77 aki77 deleted the add-response-size branch July 20, 2023 12:42
@JunichiIto
Copy link
Contributor Author

ちなみに出力例って実際の値ですか？（遅すぎて気になった）

実際の値です。
だけど、今朝試したらこんな感じでした。

Downloaded translations (6587ms, 9.0MB, 1400.4KB/s)

もしかして夜中だったから？？

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aki77 aki77 aki77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JunichiIto @aki77